Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add REGAPIC coverage #1431

Closed
wants to merge 11 commits into from
Closed

chore: Add REGAPIC coverage #1431

wants to merge 11 commits into from

Conversation

lqiu96
Copy link
Contributor

@lqiu96 lqiu96 commented Mar 2, 2023 •
edited
Loading

Thank you for opening a Pull Request! For general contributing guidelines, please refer to contributing guide

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1439 ☕️

This is a draft to experiment with having Showcase ITs to cover a bunch of the REGAPIC functionalities.
Showcase modules (currently) intended/ in scope:

  • Echo (Unary + Server Side Streaming Calls, Mixins, Timeouts, Retries)
  • Compliance (http annotations)
  • Identity (CRUD calls)

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Mar 2, 2023
@lqiu96 lqiu96 mentioned this pull request Mar 7, 2023
Closed
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@blakeli0
Copy link
Collaborator

blakeli0 commented Mar 8, 2023

I know this PR is still WIP, a general comment is that we don't have to put everything in one PR. As soon as we understand how to write a showcase integration for a certain feature, we can start adding them one by one so it's easier to review and track in the future.

@lqiu96
Copy link
Contributor Author

lqiu96 commented May 2, 2023

Closing as this is being implemented in a series of smaller PRs.

@lqiu96 lqiu96 closed this May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

REGAPIC Showcase Coverage
2 participants
@lqiu96 @blakeli0